-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up app for Jetpack's support bot integration #94768
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~8 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I verified that this builds correctly and produces a working result. As for the actual contents of the entrypoint, we'll likely change that later as well as the way the client mounts onto the page, so no need to pay a lot of attention to that just yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infrastructure seems reasonable. I didn't test it or look into the JS code.
__i18n_text_domain__: JSON.stringify( 'default' ), | ||
} ), | ||
new DependencyExtractionWebpackPlugin( { | ||
injectPolyfill: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is still needed after WordPress/gutenberg#65292. Depends on whether @wordpress/babel-preset-default
is used I think.
084d50f
to
66fc61f
Compare
Suprecedes #94082.
Proposed Changes
Adds a
jetpackme-support
app which will serve as the home for the Odie support widget onhttps://jetpack.com/contact-support
.Why are these changes being made?
Testing Instructions
yarn dev
to test whether everything builds correctly.Note that so far this doesn't affect any page in production.
Pre-merge Checklist