Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-migration Experience: Add the completion logic for the Review Site task #95144

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

valterlorran
Copy link
Contributor

Related to #39611

Proposed Changes

  • Adds the completion logic for the "Review the site's content" task.

Why are these changes being made?

  • As part of the Post-migration Experience project, we need to encourage the users to check if the site works properly after the migration. The task "Review the site's content" will redirect the user to the site's home page. It should be marked as complete upon clicking on the task.

Testing Instructions

  • Follow the testing instructions in the Jetpack change so we can display the "Review the site's content" task: Post-migration Experience: Add the "Review the site's content" task jetpack#39641
  • Apply this PR to your local environment or use Calypso live
  • Navigate to the Customer Home of your testing site and click on the "Review the site's content"
  • You should be redirected to the home page of your testing site, and the task should be marked as complete.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran requested review from a team October 4, 2024 04:12
@valterlorran valterlorran self-assigned this Oct 4, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 4, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~130 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               -423 B  (-0.0%)     -130 B  (-0.0%)
entry-main                  -359 B  (-0.0%)      -99 B  (-0.0%)
entry-login                 -359 B  (-0.0%)     -100 B  (-0.0%)
entry-subscriptions         -295 B  (-0.0%)      -82 B  (-0.0%)
entry-domains-landing       -295 B  (-0.0%)      -82 B  (-0.0%)
entry-browsehappy           -295 B  (-0.1%)      -82 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1023 bytes added 📈 [gzipped])

name                           parsed_size           gzip_size
transferring-hosted-site-flow       +251 B  (+0.2%)     +766 B  (+2.1%)
stats                               -128 B  (-0.0%)      -31 B  (-0.0%)
write-flow                           +55 B  (+0.0%)       +2 B  (+0.0%)
videopress-flow                      +55 B  (+0.0%)       +2 B  (+0.0%)
subscribers                          +55 B  (+0.0%)     +280 B  (+0.1%)
link-in-bio-tld-flow                 +55 B  (+0.0%)       +2 B  (+0.0%)
home                                 +55 B  (+0.0%)       +4 B  (+0.0%)
earn                                 +55 B  (+0.0%)       +2 B  (+0.0%)
build-flow                           +55 B  (+0.0%)       +2 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2151 bytes removed 📉 [gzipped])

name                                                 parsed_size           gzip_size
async-load-masterbar-launchpad-navigator                  +251 B  (+0.4%)     +677 B  (+3.1%)
async-load-calypso-my-sites-stats-pages-subscribers       +251 B  (+0.2%)     +750 B  (+1.6%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to another PR I raised: Automattic/jetpack#39643

Is there a reason that we don't implement all the logic in Jetpack? Should I do something similar in my PR (although I'm also checking there if the user visits the plugin page directly and I think it wouldn't work from Calypso since that is a wp-admin page)?

packages/launchpad/src/setup-actions.ts Show resolved Hide resolved
@valterlorran
Copy link
Contributor Author

@renatho I decided not to use the get_calypso_path prop because we didn't have a way to open the URL in a new tab.

@renatho renatho self-requested a review October 7, 2024 14:23
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! =)

@valterlorran valterlorran merged commit 8c8b895 into trunk Oct 7, 2024
16 checks passed
@valterlorran valterlorran deleted the add/review-site-task-completion-logic branch October 7, 2024 14:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants