Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getTitanSetUpMailboxPath for domain only sites #95210

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Oct 8, 2024

Fixes #95147

Proposed Changes

  • Allows getTitanSetUpMailboxPath access for domain only sites

Why are these changes being made?

Testing Instructions

  • From /domains/manage (Manage all domains page), purchase a domain without it being attached to a site.
  • From /email/:domain/manage/:domain (Manage emails page), purchase a titan mail email box
  • Delete the mailbox
  • Attempt to click on "Mailboxes" in the sidebar, it should re-route you to mailbox setup.
  • Click "Manage Email" in the sidebar, click the "Set up mailbox" cta in blue, it should take you to the setup page
  • Click "Manage Email" again, click "Add a mailbox", it should show a warning and provide a link to setup mailbox again, click that, the setup page should be shown again.

These links should no longer redirect to /domains/manage

Screenshot(66)

Screenshot(68)

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~2 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +26 B  (+0.0%)       +2 B  (+0.0%)
entry-main           +26 B  (+0.0%)       +1 B  (+0.0%)
entry-login          +26 B  (+0.0%)       +1 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lsl lsl requested a review from a team October 8, 2024 05:03
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 8, 2024
@lsl lsl marked this pull request as ready for review October 8, 2024 05:05
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! Although as a user I'm confused why we have two terms "Email" and "Mailbox" in the sidebar which does the same thing (but of course it's out of the scope of this PR).

@lsl lsl merged commit 90ab2fa into trunk Oct 8, 2024
15 checks passed
@lsl lsl deleted the update/mailboxroutes branch October 8, 2024 23:25
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 8, 2024
@lsl lsl self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domain only domains and mailbox routing
3 participants