Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the migration status to started on the DIY flow #95232

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

valterlorran
Copy link
Contributor

@valterlorran valterlorran commented Oct 8, 2024

Related to #95156

Proposed Changes

  • Updates the migration status sticker to started on the Instructions step for the self-serve flow.

Why are these changes being made?

  • As part of the Post-purchase project, we need to store the state of the migration using the stickers to allow us to better redirect the user back to the flow.
  • For the Post-migration experience, we need to know the status of the migration so we can show the Launchpad with for the migrated sites.

Testing Instructions

  • Apply this diff to your local environment or use Calypso live
  • Start a migration and go through the "Do it myself" flow
  • Once you reach the "Instructions" step, go to the blog's RC and verify that you have the following events in the Audit Trail panel:
    • add sticker - migration-pending-diy
    • remove sticker - migration-pending-diy
    • add sticker - migration-started-diy

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran requested review from a team October 8, 2024 23:53
@valterlorran valterlorran self-assigned this Oct 8, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 8, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 9, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/sticker-migration-start-diy on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. 👍

@valterlorran valterlorran merged commit bf31e44 into trunk Oct 9, 2024
11 checks passed
@valterlorran valterlorran deleted the add/sticker-migration-start-diy branch October 9, 2024 13:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants