Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Add sites migration banner"" #95402

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Oct 15, 2024

Adding the changes from #95298 again.

It was reverted on #95388 as a test because of build tests, but it wasn't the cause.

@renatho renatho self-assigned this Oct 15, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 15, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~983 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
staging-site                          +769 B  (+0.0%)     +247 B  (+0.1%)
sites-dashboard                       +769 B  (+0.1%)     +247 B  (+0.1%)
site-performance                      +769 B  (+0.0%)     +247 B  (+0.1%)
site-monitoring                       +769 B  (+0.1%)     +247 B  (+0.1%)
site-logs                             +769 B  (+0.1%)     +247 B  (+0.1%)
hosting-features                      +769 B  (+0.1%)     +247 B  (+0.1%)
hosting                               +769 B  (+0.0%)     +247 B  (+0.0%)
github-deployments                    +769 B  (+0.1%)     +247 B  (+0.1%)
write-flow                            +334 B  (+0.0%)      +54 B  (+0.0%)
videopress-flow                       +334 B  (+0.0%)      +49 B  (+0.0%)
update-design-flow                    +334 B  (+0.0%)      +55 B  (+0.0%)
themes                                +334 B  (+0.0%)      +49 B  (+0.0%)
theme                                 +334 B  (+0.0%)      +53 B  (+0.0%)
stats                                 +334 B  (+0.0%)      +55 B  (+0.0%)
site-purchases                        +334 B  (+0.0%)      +47 B  (+0.0%)
site-blocks                           +334 B  (+0.0%)      +54 B  (+0.0%)
settings-security                     +334 B  (+0.1%)      +54 B  (+0.0%)
settings-podcast                      +334 B  (+0.1%)      +54 B  (+0.0%)
settings-performance                  +334 B  (+0.1%)      +54 B  (+0.0%)
settings                              +334 B  (+0.0%)      +47 B  (+0.0%)
sensei-flow                           +334 B  (+0.1%)      +54 B  (+0.0%)
security                              +334 B  (+0.0%)      +46 B  (+0.0%)
reader                                +334 B  (+0.0%)      +42 B  (+0.0%)
purchases                             +334 B  (+0.0%)      +47 B  (+0.0%)
privacy                               +334 B  (+0.0%)      +54 B  (+0.0%)
posts-custom                          +334 B  (+0.1%)      +54 B  (+0.0%)
posts                                 +334 B  (+0.0%)      +54 B  (+0.0%)
plugins                               +334 B  (+0.0%)      +47 B  (+0.0%)
plans                                 +334 B  (+0.0%)      +49 B  (+0.0%)
people                                +334 B  (+0.1%)      +54 B  (+0.0%)
notification-settings                 +334 B  (+0.0%)      +54 B  (+0.0%)
media                                 +334 B  (+0.0%)      +46 B  (+0.0%)
me                                    +334 B  (+0.0%)      +54 B  (+0.0%)
marketing                             +334 B  (+0.0%)      +54 B  (+0.0%)
link-in-bio-tld-flow                  +334 B  (+0.0%)      +49 B  (+0.0%)
jetpack-cloud-plugin-management       +334 B  (+0.0%)      +47 B  (+0.0%)
jetpack-cloud-partner-portal          +334 B  (+0.0%)      +54 B  (+0.0%)
jetpack-cloud-agency-sites-v2         +334 B  (+0.0%)      +41 B  (+0.0%)
home                                  +334 B  (+0.0%)      +49 B  (+0.0%)
help                                  +334 B  (+0.0%)      +54 B  (+0.0%)
email                                 +334 B  (+0.0%)      +54 B  (+0.0%)
earn                                  +334 B  (+0.0%)      +55 B  (+0.0%)
domains                               +334 B  (+0.0%)      +47 B  (+0.0%)
developer                             +334 B  (+0.0%)      +54 B  (+0.0%)
copy-site-flow                        +334 B  (+0.0%)      +54 B  (+0.0%)
build-flow                            +334 B  (+0.0%)      +54 B  (+0.0%)
backup                                +334 B  (+0.0%)      +54 B  (+0.0%)
activity                              +334 B  (+0.0%)      +54 B  (+0.0%)
account-close                         +334 B  (+0.0%)      +54 B  (+0.0%)
account                               +334 B  (+0.0%)      +47 B  (+0.0%)
a8c-for-agencies-sites                +334 B  (+0.0%)      +41 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~103 bytes added 📈 [gzipped])

name                                                     parsed_size           gzip_size
async-load-signup-steps-domains                               +334 B  (+0.1%)      +54 B  (+0.0%)
async-load-design-playground                                  +334 B  (+0.0%)      +54 B  (+0.0%)
async-load-design-blocks                                      +334 B  (+0.0%)      +49 B  (+0.0%)
async-load-design                                             +334 B  (+0.0%)      +54 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal             +334 B  (+0.0%)      +54 B  (+0.0%)
async-load-calypso-my-sites-current-site-notice               +334 B  (+0.6%)      +54 B  (+0.3%)
async-load-calypso-components-web-preview-component           +334 B  (+0.1%)      +54 B  (+0.0%)
async-load-calypso-blocks-jitm-templates-sidebar-banner       +334 B  (+0.7%)      +54 B  (+0.3%)
async-load-calypso-blocks-jitm-templates-notice               +334 B  (+0.7%)      +54 B  (+0.3%)
async-load-calypso-blocks-jitm-templates-default              +334 B  (+0.7%)      +54 B  (+0.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@renatho renatho force-pushed the revert-95388-revert-95298-add/sites-migration-banner branch from cbcbe96 to de5f631 Compare October 15, 2024 18:08
@renatho renatho merged commit 931697c into trunk Oct 15, 2024
11 checks passed
@renatho renatho deleted the revert-95388-revert-95298-add/sites-migration-banner branch October 15, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants