Start: Fix isNewUser logic, take 2

[escapemanuele]

Fixes #95347

Proposed Changes

Change the way in which the isNewUser variable is calculated in Start, when the onboarding flow is completed. That variable is then used to decide the value of isNew7DUserSite, used to decide if we need to fire the calypso_new_user_site_creation event.

With the changes, isNewUser will be based on response.created_account response value that we get when we create a new user, during the onboarding flow.

Why are these changes being made?

isNewUser was calculated on the value of dependencies.username. We can see how username has value even when the signup type is social and created_account is false.

That's not correct.

This led to the wrong firing of the calypso_new_user_site_creation event, even for old social accounts. It is terrible during our Start/Stepper experiment, as calypso_new_user_site_creation events are many more in Start due to this error.

Testing Instructions

• Run yarn start-mock-wordpress-com
• Go to /start and use Google with an already existing account
• Go through the onboarding flow and you should not see calypso_new_user_site_creation being triggered.
• Go through production to check if you can instead reproduce the issue.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-121925

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-121925&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-121925&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-95394-revert-95375-start-fix-new-user on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~19 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +170 B  (+0.0%)      +19 B  (+0.0%)
entry-main          +170 B  (+0.0%)      +19 B  (+0.0%)
entry-login         +170 B  (+0.0%)      +19 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~330 bytes added 📈 [gzipped])

name                           parsed_size           gzip_size
signup                               +85 B  (+0.0%)      +40 B  (+0.1%)
link-in-bio-tld-flow                 +81 B  (+0.0%)      +32 B  (+0.0%)
write-flow                           +64 B  (+0.0%)      +28 B  (+0.0%)
videopress-tv-flow                   +64 B  (+0.1%)      +31 B  (+0.1%)
videopress-flow                      +64 B  (+0.0%)      +27 B  (+0.0%)
transferring-hosted-site-flow        +64 B  (+0.1%)      +32 B  (+0.1%)
sensei-flow                          +64 B  (+0.0%)      +31 B  (+0.0%)
plugin-bundle-flow                   +64 B  (+0.0%)      +31 B  (+0.0%)
import-hosted-site-flow              +64 B  (+0.0%)      +26 B  (+0.0%)
copy-site-flow                       +64 B  (+0.0%)      +31 B  (+0.0%)
build-flow                           +64 B  (+0.0%)      +33 B  (+0.0%)
update-design-flow                   +61 B  (+0.0%)      +32 B  (+0.0%)
onboarding-flow                      +44 B  (+0.2%)      +20 B  (+0.3%)
jetpack-connect                      +44 B  (+0.0%)      +18 B  (+0.0%)
accept-invite                        +44 B  (+0.0%)      +19 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~21 bytes added 📈 [gzipped])

name                                     parsed_size           gzip_size
async-load-calypso-lib-analytics-signup        +44 B  (+0.3%)      +21 B  (+0.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.