Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A4A > Agency Tier: Implement top badge section #95422

Merged
merged 1 commit into from
Oct 17, 2024
Merged

A4A > Agency Tier: Implement top badge section #95422

merged 1 commit into from
Oct 17, 2024

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Oct 16, 2024

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1293

Proposed Changes

This PR implements the badge section for the agency tier page.

Why are these changes being made?

  • To showcase the current agency tier for the user.

Testing Instructions

  • Open the A4A live link
  • Update your agency tier to Emerging Partner using the MC tool > Go to Agency Tier in the UI > Verify the screen looks as shown below:
Screenshot 2024-10-16 at 12 47 15 PM
  • Change the agency tier to Agency Partner > Refresh the UI and verify the screen looks as shown below:
Screenshot 2024-10-16 at 12 47 27 PM
  • Change the agency tier to Pro Agency Partner > Refresh the UI and verify the screen looks as shown below:
Screenshot 2024-10-16 at 12 47 40 PM
  • Verify it looks good on all the screen sizes:
Screenshot 2024-10-16 at 12 52 45 PM Screenshot 2024-10-16 at 12 54 08 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested a review from a team October 16, 2024 07:41
@yashwin yashwin self-assigned this Oct 16, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-122064
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-122064&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-122064&env=a8c-for-agencies

@matticbot
Copy link
Contributor

matticbot commented Oct 16, 2024 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~468 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-agency-tier      +2153 B  (+1.1%)     +468 B  (+0.8%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin force-pushed the add/a4a/agency-tier/implement-top-badge-section branch from ba1bb3c to dcf2cce Compare October 16, 2024 08:59
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/agency-tier/implement-top-badge-section on your sandbox.

@yashwin yashwin mentioned this pull request Oct 16, 2024
Merged
7 tasks
@jkguidaven
Copy link
Contributor

In the mobile view: It looks like the header has too much spacing.

Screenshot 2024-10-17 at 2 29 52 PM

jkguidaven
jkguidaven approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, and I can confirm it is working as expected. I have a few minor comments, but they are non-blockers. The issue with the mobile view can be addressed in a separate PR.

client/a8c-for-agencies/sections/agency-tier/lib/get-agency-tier-info.tsx
agencyTier: 'emerging-partner' | 'agency-partner' | 'pro-agency-partner',
translate: ( key: string, args?: Record< string, unknown > ) => string
) => {
let tierInfo = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking: Instead of having a variable, maybe just return the value within the switch case.

client/a8c-for-agencies/sections/agency-tier/primary/agency-tier-overview/index.tsx
</Subtitle>
<Actions>
<MobileSidebarNavigation />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why we moved this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was causing some extra padding.

@yashwin yashwin merged commit bc78002 into trunk Oct 17, 2024
11 checks passed
@yashwin yashwin deleted the add/a4a/agency-tier/implement-top-badge-section branch October 17, 2024 07:05
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2024
@yashwin
Copy link
Contributor Author

yashwin commented Oct 17, 2024

Thanks for the review, @jkguidaven!

As discussed, I'll be addressing your comments in a separate PR.

@a8ci18n
Copy link

a8ci18n commented Oct 17, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16920174

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 21, 2024 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16920174

Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 30, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkguidaven jkguidaven jkguidaven approved these changes

Assignees

@yashwin yashwin

Labels
A8c Agencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yashwin @matticbot @jkguidaven @a8ci18n