Stats: Remove legacy purchase page forced redirection

[dognose24]

Related to https://github.com/Automattic/red-team/issues/139

Proposed Changes

• Remove the unused code from the always false condition about the shouldRenderPaywall flag.
• Remove possibly unused notice id focus_jetpack_purchase and related code, which seemed to pause the redirection for the Personal purchase page after clicking the I will do it later button.

Why are these changes being made?

• The force purchase page redirection is no longer used. We use a paywall lock on each module or card now. More information: pejTkB-1t3-p2.

Testing Instructions

• Spin this change up with the Calypso Live branch.
• Prepare a site with the commercial paywall.
• Ensure the module paywall on Stats Traffic, Insights, and module pages work as previously.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-122152

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-122152&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-122152&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~627 bytes removed 📉 [gzipped])

name                parsed_size           gzip_size
stats                   -1960 B  (-0.2%)     -619 B  (-0.2%)
google-my-business        -26 B  (-0.0%)       -8 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~103 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-purchase       +213 B  (+0.3%)     +111 B  (+0.6%)
async-load-store-app-store-stats                        -26 B  (-0.0%)       -8 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[kangzj]

It feels the whole stats-redirect module could be removed, couldn't it?

[dognose24]

Good catch! Indeed, the LoadStatsPage component has already checked the user with authority.

[dognose24]

Addressed in 0d909a1.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• command-palette-wp-admin
• help-center
• notifications
• odyssey-stats
• whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats_remove_legacy_purchase_page_redirection on your sandbox.

[dognose24]

I will split the refactor for the stats-redirect folder to another PR.