-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader Onboarding: add industry curated blogs #95444
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~2143 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
d7773fd
to
338689d
Compare
}, | ||
{ | ||
feed_ID: 200540198, | ||
site_ID: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was seeing blog_ID: 0
in the data for external sites. Using null
was incompatible with the CardData
interface so I went this route. It seems to work fine.
I also noticed that blogs you've already subscribed to can show up (see screenshot; Matt's blog). It doesn't make sense for those to be shown because the intention is to surface new blogs you may like, not ones you already like. But since this is a v1, and I think this an edge case for most users that will go through onboarding, I say we roll with it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for curating these sites!
Related to Automattic/dotcom-forge#9439
Proposed Changes
(With Space, Business, and Remote Work followed)
Why are these changes being made?
Testing Instructions
/read?flags=reader/onboarding
Pre-merge Checklist