Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Onboarding: add industry curated blogs #95444

Merged
merged 16 commits into from
Oct 18, 2024
Merged

Conversation

holdercp
Copy link
Contributor

@holdercp holdercp commented Oct 16, 2024

Related to Automattic/dotcom-forge#9439

Proposed Changes

  • Adds curated feeds/blogs for various industry sub-topics

(With Space, Business, and Remote Work followed)

Before After
image image

Why are these changes being made?

  • The provide a better UX when suggesting sites users should subscribe to after they follow a tag

Testing Instructions

  • Subscribe to at least three of the curated industry tags: "business", "startups", "finance", "space", "leadership", "marketing", "remote work", "saas", or "creator economy"
  • Navigate to /read?flags=reader/onboarding
  • Click "Discover and subscribe to sites you'll love"
  • Check to see that recommendations make sense and you are able to subscribe

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Oct 16, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2143 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader      +6366 B  (+0.6%)    +2143 B  (+0.7%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/industry-curated-blogs on your sandbox.

@holdercp holdercp force-pushed the add/industry-curated-blogs branch from d7773fd to 338689d Compare October 18, 2024 02:31
@holdercp holdercp marked this pull request as ready for review October 18, 2024 03:16
@holdercp holdercp requested a review from a team as a code owner October 18, 2024 03:16
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
},
{
feed_ID: 200540198,
site_ID: 0,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was seeing blog_ID: 0 in the data for external sites. Using null was incompatible with the CardData interface so I went this route. It seems to work fine.

@holdercp
Copy link
Contributor Author

holdercp commented Oct 18, 2024

I also noticed that blogs you've already subscribed to can show up (see screenshot; Matt's blog). It doesn't make sense for those to be shown because the intention is to surface new blogs you may like, not ones you already like. But since this is a v1, and I think this an edge case for most users that will go through onboarding, I say we roll with it for now.

Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for curating these sites!

@holdercp holdercp merged commit 012143e into trunk Oct 18, 2024
11 checks passed
@holdercp holdercp deleted the add/industry-curated-blogs branch October 18, 2024 20:16
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
@holdercp holdercp self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants