-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader Onboarding: Implement preview pane and selectable sites #95445
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~330 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~88 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
18f9abf
to
a0ef094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress looks great!
Related to https://github.com/Automattic/loop/issues/188
Proposed Changes
onItemClick
andisSelected
props to theConnectedReaderSubscriptionListItem
andReaderSubscriptionListItem
components.Note
This PR does NOT implement a "completed" state when you click the "Continue" button. We'll handle that in a followup PR. It also does NOT implement the "Load more recommendations" feature, but the copy is left in to keep the translations warm.
Why are these changes being made?
Testing Instructions
Pre-merge Checklist