Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcasting Settings: Don't show the plan upsell nudge if the plan already support audio upload #95447

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

taipeicoder
Copy link
Contributor

Fixes #87105

Proposed Changes

This PR fixes an issue where the plan upsell nudge is still displayed even when the site is on a plan that supports audio uploads.

Why are these changes being made?

Overall WordPress.com polish.

Testing Instructions

  • Using a site with a Free plan, head to /settings/podcasting/{SITE}.
  • Ensure that the upsell nudge is displayed.
  • Using a site with a Personal plan, head to /settings/podcasting/{SITE}.
  • Ensure that the upsell nudge is displayed.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@taipeicoder taipeicoder self-assigned this Oct 17, 2024
@taipeicoder taipeicoder requested a review from a team October 17, 2024 03:51
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2024
@taipeicoder taipeicoder added Lego Maintenance and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 17, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/settings-podcasting-upsell-nudge on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~60 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
settings-podcast       +107 B  (+0.0%)      +60 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected 🙌

@taipeicoder taipeicoder merged commit fd9dc97 into trunk Oct 18, 2024
14 of 16 checks passed
@taipeicoder taipeicoder deleted the update/settings-podcasting-upsell-nudge branch October 18, 2024 01:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
@taipeicoder taipeicoder restored the update/settings-podcasting-upsell-nudge branch October 18, 2024 04:09
@taipeicoder taipeicoder deleted the update/settings-podcasting-upsell-nudge branch October 18, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podcast: "Upload audio" nudge still present even with the Starter plan
3 participants