-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BackupScheduleSetting: enable fetching and updating schedule time #95449
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~149 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~6566 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Refactor convertHourToRange to consider UTC as a 24-hour format. Also, I’m shifting from building the time range manually, to use moment().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16927149 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @Initsogar, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16927149 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @Initsogar, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Related to https://github.com/Automattic/jetpack-backup-team/issues/669
Proposed Changes
Allow users to update their daily backup time schedule. This is still under the
jetpack/backup-schedule-setting
until we decide to release it.useScheduledTimeQuery
to handle scheduled time fetch. This one will be reused to display the scheduled time in theLatest backup
section as part of https://github.com/Automattic/jetpack-backup-team/issues/700useScheduledTimeMutation
to handle scheduled time updatejetpack/backup-schedule-setting
on Jetpack Cloud development and horizon (live branches) environmentsDemo
CleanShot.2024-10-18.at.09.06.40.mp4
Why are these changes being made?
https://github.com/Automattic/jetpack-backup-team/issues/669
Testing Instructions
Daily backup time schedule
setting at the bottom of the pageDefault time
messageDaily backup time successfully changed.
Time set by <user>. UTC: X:XX - X:XX XX
.UTC: X:XX - X:XX XX
will be the UTC time of the schedule time saved.Pre-merge Checklist