Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social | Clear Bluesky connection form after connection #95461

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

manzoorwanijk
Copy link
Member

After we changed the external_display logic for Bluesky in D163108-code, the connection form for Bluesky stopped getting cleared after the connection is complete.

Proposed Changes

  • Fix the handle name for checking whether a Bluesky account is already connected
  • Thus, fix the issue of the form not getting cleared after connection is complete

Why are these changes being made?

Testing Instructions

  • Goto /marketing/connections/:site
  • Connect a Bluesky account
  • Confirm that the form gets cleared after connection is complete

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@manzoorwanijk manzoorwanijk added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2024
@manzoorwanijk manzoorwanijk requested a review from a team October 17, 2024 10:13
@manzoorwanijk manzoorwanijk self-assigned this Oct 17, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/social-bluesky-clear-form-after-connection on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~13 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
marketing             -17 B  (-0.0%)      +13 B  (+0.0%)
jetpack-social        -17 B  (-0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, form clears out after adding a new connection

@manzoorwanijk manzoorwanijk merged commit 1dbdbcf into trunk Oct 17, 2024
14 checks passed
@manzoorwanijk manzoorwanijk deleted the fix/social-bluesky-clear-form-after-connection branch October 17, 2024 10:44
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants