-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Display Pressable plan usage information #95485
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~12 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~4314 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
client/a8c-for-agencies/components/pressable-usage-details/index.tsx
Outdated
Show resolved
Hide resolved
...r-agencies/sections/marketplace/hosting-overview/hosting-v2/premier-agency-hosting/index.tsx
Show resolved
Hide resolved
client/a8c-for-agencies/components/pressable-usage-details/style.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cleacos, lgtm!
3230b93
to
0dea43a
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16927665 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @cleacos for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Resolves: https://github.com/Automattic/automattic-for-agencies-dev/issues/1124
Proposed Changes
This PR adds the current Pressable plan usage overview to the Marketplace > hosting section:
Desktop
Mobile
Purchases > Licenses section
Agency without Pressable usage data
If an A4A Pressable agency doesn't have usage data, for instance, the first day because the usage information is not available until the next day, we have to display this case with
?
as valueTesting Instructions
Pre-merge Checklist