-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans: update "Limited time offer" to "Special offer" #95522
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! Since the string is not translated, can we add a fallback using useHasEnTranslation
? Or maybe add the "String Freeze" label if the change is not urgent?
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16928151 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @michaeldcain for including a screenshot in the description! This is really helpful for our translators. |
@michaelpick once clarified about the usage of title casing here: pau2Xa-5Sh-p2#comment-15417
Thus, I'm wondering if we should use this opportunity to update the capitalization as well, to "Special offer" instead 🤔 |
Hey @southp! I'm not sure we've ever settled on a style rule for labels, but looking at the 'Best for' labels at the top of the same grid they appear to be sentence case, so I'd say consistency would be a good call here. |
@southp thanks for the suggestion. Since the new string is 81% translated, I might go ahead and merge this and then follow-up with a change to the casing. I'm pretty sure the translation will get picked up by our fuzzy matching, but don't want to queue a retranslation at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Translation for this Pull Request has now been finished. |
When we switched the local currency discounts to use introductory offers in #86434, we consolidated the logic for the offer pill to use the same "Limited time offer" text as the Woo Express plans that were already utilizing introductory offers. @niranjan-uma-shankar then pointed out that since these promotions are longer-running, we shouldn't use the "limited time" wording (p58i-fkS-p2#comment-64883).
This PR update the text to use the wording "Special offer", which falls within the constraint of "unique to our normal business offerings". I understand that the original wording was "One time discount", but since this is the fallback wording for all introductory offers, "Special offer" felt more applicable. We can add conditions to use "One time discount" for these specific offers in a follow-up if it's needed.
To test:
INR
,PHP
, orMXN
currencies, on a site that hasn't previously had a plan purchase: