Social: Fix broken calypso sharing experience when toggling off connections

[spsiddarthan]

When two Facebook pages belonging to the same Facebook account are connected, toggling off one connection, toggles the other as well. The calypso connection screen still used the old keyring token id checks. This PR fixes it.

Related to #

Proposed Changes

• Updated the logic to skip sharing/toggling off connections to use the publicize connection id, instead of the keyring token_id.

Why are these changes being made?

• Toggling off sharing is broken in the calypso sharing screen.

Testing Instructions

• On a WPCOM site, buy the WordPress premium plan, so you have the resharing feature.
• Connect Jetpack Social connections. Make sure you have at least 2 facebook pages connected and 1 non Facebook connection.
• Go to wordpress.com/posts/site/your-site-wordpress.com
• Share just to one Facebook page, while the other is toggled off. If you try doing the same on trunk, you will see that, toggling off one Facebook page toggles off the other as well.

Before

After

Only the selected connection will be toggled off.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-122319

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-122319&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-122319&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/calypso-sharing on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~22 bytes removed 📉 [gzipped])

name          parsed_size           gzip_size
posts-custom       -114 B  (-0.0%)      -22 B  (-0.0%)
posts              -114 B  (-0.0%)      -22 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~22 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks       -114 B  (-0.0%)      -22 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[manzoorwanijk]

Works great

Screen.Recording.2024-10-21.at.2.24.32.PM.mov