Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Fix activating the default style variation led to the upgrade nudges showing up #95542

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

arthur791004
Copy link
Contributor

Related to #93826

Proposed Changes

  • Avoid showing upgrade nudges in the Site Editor when people activated the default style variation from the Theme Showcase

Why are these changes being made?

Testing Instructions

  • Be on a free site
  • Go to /themes
  • Click a style variation disc on the theme showcase grid
  • Click the default variation disc
  • Click into the theme
  • Activate it
  • Look at the front-end of the site, or the site editor
  • Make sure the upgrade nudges don't show up

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Oct 21, 2024
@arthur791004 arthur791004 requested a review from a team October 21, 2024 08:53
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/default-style-variation on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~21 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
themes                         +17 B  (+0.0%)       +6 B  (+0.0%)
theme                          +17 B  (+0.0%)       +6 B  (+0.0%)
readymade-template-flow        +17 B  (+0.0%)       +9 B  (+0.0%)
marketplace                    +17 B  (+0.0%)       +6 B  (+0.0%)
checkout                       +17 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~6 bytes added 📈 [gzipped])

name                                     parsed_size           gzip_size
async-load-signup-steps-theme-selection        +17 B  (+0.0%)       +6 B  (+0.0%)
async-load-design-blocks                       +17 B  (+0.0%)       +6 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nasty bug 🤦

@arthur791004 arthur791004 merged commit 8bab616 into trunk Oct 22, 2024
15 checks passed
@arthur791004 arthur791004 deleted the fix/default-style-variation branch October 22, 2024 02:33
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants