Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove english based verifications #95552

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Oct 21, 2024

Proposed Changes

  • Remove translation verification since the phrases are already available in all languages.

Testing Instructions

  • Access the screen using any of the supported languages and check if you can see any message in English (visual inspection is also ok).
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@gabrielcaires gabrielcaires marked this pull request as ready for review October 21, 2024 14:11
@gabrielcaires gabrielcaires self-assigned this Oct 21, 2024
@gabrielcaires gabrielcaires requested a review from a team October 21, 2024 14:11
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2024
@gabrielcaires gabrielcaires added [Feature] Site Migration Features related to site migrations to WPcom [Type] Enhancement and removed [Type] Enhancement labels Oct 21, 2024
Copy link
Contributor

@daledupreez daledupreez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes overall look good to me and test well, but I think we may need to include the _locale URL parameter when calling the server, as the error messages don't seem to be translated. You can see that in the video below with my language set to Dutch.

Screen.Recording.2024-10-23.at.11.39.03.mov

@gabrielcaires
Copy link
Contributor Author

The changes overall look good to me and test well, but I think we may need to include the _locale URL parameter when calling the server, as the error messages don't seem to be translated. You can see that in the video below with my language set to Dutch.

@daledupreez I am going to open another issue to fix it

@gabrielcaires gabrielcaires merged commit 9448fd1 into trunk Oct 23, 2024
16 of 18 checks passed
@gabrielcaires gabrielcaires deleted the update/remove-english-gateways branch October 23, 2024 17:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Migration Features related to site migrations to WPcom [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants