Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Details: Avoid prefetch unlisted plugins #95553

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Plugin Details: Avoid prefetch unlisted plugins #95553

merged 1 commit into from
Oct 21, 2024

Conversation

WBerredo
Copy link
Contributor

Proposed Changes

  • Avoid prefetch of unlisted plugins
  • Avoid render alternate links for unlisted plugins

Why are these changes being made?

p1729195801390409-slack-C02JPCHEKDY

Testing Instructions

  • Go to /plugins/wp-fusion-lite
  • Look for alternate on the rendered elements
  • You should find ZERO results
Before After
CleanShot 2024-10-21 at 11 08 25@2x CleanShot 2024-10-21 at 10 59 20@2x

@github-actions GitHub Actions
Copy link

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-ea4ca51e846cfe4b2b372dd79a2c40133e17c3f3
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-ea4ca51e846cfe4b2b372dd79a2c40133e17c3f3&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-ea4ca51e846cfe4b2b372dd79a2c40133e17c3f3&env=a8c-for-agencies

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

cpapazoglou
cpapazoglou approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me, thanks!

@WBerredo WBerredo merged commit 2d68e51 into trunk Oct 21, 2024
12 checks passed
@WBerredo WBerredo deleted the fix/avoid-prefetch-unlisted-plugins branch October 21, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpapazoglou cpapazoglou cpapazoglou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WBerredo @matticbot @cpapazoglou