Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paid stats: restrict date picker to 7 days instead of 30 #96995

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Dec 3, 2024

Fixes https://github.com/Automattic/jetpack-roadmap/issues/2017

Proposed Changes

  • Limit date picker access to 7 days unless the user has paid stats

Todo:

  • Fix the styling of the disabled date ranges
  • Ensure the 7 day shortcut is selected

Testing Instructions

  • Load stats for a site with no plan
  • Confirm the date picker is defaults to and is limited to 7 days

Before

Screenshot(152)

After

Screenshot(153)

@lsl lsl self-assigned this Dec 3, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats7days on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@kangzj kangzj added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 3, 2024
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I think I we accidentally broke the shortcuts. I'll come up with a fix. Thanks @lsl

@kangzj kangzj merged commit af06cf5 into trunk Dec 4, 2024
14 checks passed
@kangzj kangzj deleted the update/stats7days branch December 4, 2024 03:00
@kangzj kangzj mentioned this pull request Dec 4, 2024
8 tasks
@kangzj
Copy link
Contributor

kangzj commented Dec 4, 2024

@lsl Fix for gating is here: #97037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants