Domains: Fix WSOD during domain checkout #97028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97024.
Proposed Changes
Fixes a WSOD introduced indirectly in #96568 -
domain
can possibly beundefined
, but this isn't accounted for since its type definition is invalid - we should fix this in the future, but for now, this PR only fixes the WSOD on it, by adding optional chaining so we can preventundefined
value checks.Why are these changes being made?
A WSOD can happen during the post-checkout ("thank you") page for a domain.
Testing Instructions
Same as #97024:
calypso.live
link;Preview
Pre-merge Checklist