Goals first: Enable back button in the login step for the DIFM and Import flows #97722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
matticbot
added
the
[Status] Needs Review
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~259 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~75 bytes added 📈 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
zaguiini
changed the title
vykes-mac
reviewed
Dec 21, 2024
client/signup/steps/user/index.jsx
Outdated
| @@ -753,9 +753,13 @@ export class UserStep extends Component { | |||
| return null; | |||
| } | |||
|
|
|||
| const backUrl = this.props.backUrl?.startsWith( '/' ) ? this.props.backUrl : undefined; | |||
There was a problem hiding this comment.
non-blocking: maybe move this piece into the connect wrapper
vykes-mac
reviewed
Dec 21, 2024
zaguiini
force-pushed
the
goals-first/allow-clicking-back-from-difm-and-import
branch
from
04c6218 to
718900a
Compare
|
Thanks @vykes-mac this should be ready to go now |
zaguiini
deleted the
goals-first/allow-clicking-back-from-difm-and-import
branch
github-actions
bot
removed
the
[Status] Needs Review
candy02058912
pushed a commit
that referenced
this pull request
Dec 25, 2024
…port flows (#97722) * Accept back_url query parameter in signup/user * Accept back_url query parameter in setup/hosted-site-migration * Add back_url to DIFM and hosted-site-migration flows * Move back_url conciliation within redux connect function * Update implementation so it uses back_to instead of back_url * Push back button to the right so it doesn't conflict with the WP Logo * Update unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97706.
Proposed Changes
Title. I'm not sure if the chosen approach here is the best - please let me know if there's a better way of achieving it for both flows.
Why are these changes being made?
Continuity, UX.
Testing Instructions
Enter
/setup/onboardingand click the DIFM link. You should be redirected to the login screen with the back button enabled and that button should send you back to the goals screen.Do the same for the import link in the goals step.