Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Checkout: add note after purchasing a Jetpack license #97727

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

Initsogar
Copy link
Contributor

@Initsogar Initsogar commented Dec 21, 2024

Resolves https://github.com/Automattic/jetpack-backup-team/issues/601

Proposed Changes

  • Add note after purchasing a Jetpack license
Before After
CleanShot 2024-12-20 at 20 56 00@2x CleanShot 2024-12-20 at 20 55 31@2x

Why are these changes being made?

https://github.com/Automattic/jetpack-backup-team/issues/601

Testing Instructions

  • Go to https://cloud.jetpack.com/pricing
  • Purchase a Jetpack VaultPress Backup plan
  • When it prompts you to select a site to apply the plan, select I don't see my site. Let me configure it manually.
    CleanShot 2024-12-20 at 20 59 55@2x
  • When you are on the Ok, let's install Jetpack (...) screen, copy the URL and now replace wordpress.com with your Calypso Blue live branch domain
  • Ensure you see the new note below the license key (as shared in the screenshot above).

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/jetpack-checkout-license-helper on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~32 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout       +136 B  (+0.0%)      +32 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@Initsogar Initsogar self-assigned this Dec 21, 2024
@Initsogar Initsogar requested a review from a team December 21, 2024 02:10
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 21, 2024
@mavegaf
Copy link
Contributor

mavegaf commented Dec 21, 2024

LGTM

Screenshot 2024-12-20 at 23 29 18

@Initsogar Initsogar merged commit 63f8f30 into trunk Dec 23, 2024
16 checks passed
@Initsogar Initsogar deleted the update/jetpack-checkout-license-helper branch December 23, 2024 12:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 23, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 23, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17076065

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @Initsogar for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 29, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants