Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email stats: update icons #97744

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Email stats: update icons #97744

merged 2 commits into from
Dec 23, 2024

Conversation

simison
Copy link
Member

@simison simison commented Dec 23, 2024

Part of Automattic/jetpack#40659

Designs:
i1: p1HpG7-v7v-p2
i2: p1HpG7-vch-p2

This isn't yet exactly like in designs but nudges us towards combining the two tabs with less changes.

Proposed Changes

  • Update email stats icons; uses WP icons instead of Gridicons

Before

Screenshot 2024-12-23 at 15 22 01 Screenshot 2024-12-23 at 15 22 04

After

Screenshot 2024-12-23 at 15 19 57 Screenshot 2024-12-23 at 15 19 53

Why are these changes being made?

Testing Instructions

  • See open/click email tabs.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@simison simison requested a review from a team December 23, 2024 13:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 23, 2024
@simison simison added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 23, 2024
@simison simison added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 23, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 23, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~839 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats      +2612 B  (+0.2%)     +839 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~782 bytes removed 📉 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-insights      -1768 B  (-3.1%)     -782 B  (-4.6%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/email-stats-icons on your sandbox.

@a8ci18n
Copy link

a8ci18n commented Dec 23, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17076074

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @simison for including a screenshot in the description! This is really helpful for our translators.

@simison simison force-pushed the update/email-stats-icons branch 2 times, most recently from 7d5a857 to ab628f7 Compare December 23, 2024 15:37
Copy link
Contributor

@edanzer edanzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests as expected and changes look good.

@edanzer edanzer force-pushed the update/email-stats-icons branch from ab628f7 to ec8a385 Compare December 23, 2024 18:59
@edanzer
Copy link
Contributor

edanzer commented Dec 23, 2024

Resolved a small merge conflict following my merge of #97726

@edanzer edanzer merged commit 9aafa2f into trunk Dec 23, 2024
11 checks passed
@edanzer edanzer deleted the update/email-stats-icons branch December 23, 2024 19:15
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Dec 23, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 23, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17076074

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @simison for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 29, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants