Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Home: Add Change Theme to Quick Links #97796

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

taipeicoder
Copy link
Contributor

@taipeicoder taipeicoder commented Dec 26, 2024

Fixes #94063

Proposed Changes

This PR adds "Change theme" to the Quick Links section in My Home.

It turns out that the "Change theme" quick link was already implemented, but never rendered since the capability switch_themes seems to be filtered out from the endpoint. Thus, we check for manage_option instead to follow the Explore Plugins quick link. Another option would be to check for edit_theme_options which is available.

Why are these changes being made?

Contributes to the overall polish of WordPress.com.

Testing Instructions

  • Go to /home/:domain
  • Ensure that the "Change theme" quick link is now available
  • In the Default admin interface, it should link to /themes/:domain
  • In the Classic admin interface, it should link to themes.php

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@taipeicoder taipeicoder self-assigned this Dec 26, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2 bytes removed 📉 [gzipped])

name  parsed_size           gzip_size
home        +54 B  (+0.0%)       -2 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@taipeicoder taipeicoder marked this pull request as ready for review December 26, 2024 07:50
@taipeicoder taipeicoder requested a review from a team December 26, 2024 07:50
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 26, 2024
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on both Default and Classic interfaces 👍

@taipeicoder taipeicoder merged commit 3990b1e into trunk Dec 26, 2024
16 of 18 checks passed
@taipeicoder taipeicoder deleted the add/my-home-quicklink-change-theme branch December 26, 2024 08:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a “Change theme” quick action to My Home
3 participants