Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide manage site button for detached domains #97799

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Dec 26, 2024

Related to #97644

Proposed Changes

  • Don't show "Manage site" button when Domain is not attached

Why are these changes being made?

  • Domain management revamp

Testing Instructions

  • Enable the feature flag window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
  • Go to calypso.localhost:3000/domains/manage
  • Make sure you have domains that are attached to sites and some domains that are not attached
  • Select a detached domain, it should open in flyout. Make sure the "Manage site" button is not there
  • Select an attached domain, make sure the "Manage site button is the"ere

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Imran92 Imran92 requested a review from a team December 26, 2024 13:29
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 26, 2024
@Imran92 Imran92 self-assigned this Dec 26, 2024
@Imran92 Imran92 linked an issue Dec 26, 2024 that may be closed by this pull request
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains        +32 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. 🚢

@Imran92 Imran92 merged commit 28f8bd6 into trunk Dec 26, 2024
14 checks passed
@Imran92 Imran92 deleted the add/hide-manage-site-button-for-detached branch December 26, 2024 19:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the "Manage Site" button conditionally visible
3 participants