-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: add Geochart regions/cities #98055
Conversation
It will be less confusing when used together with statType and it's also consistent with the useLocationViewsQuery arguments.
Regions/cities should be marked as circles, instead of coloring the entire country.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~75 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -30,9 +30,9 @@ const OPTION_KEYS = { | |||
CITIES: 'cities', | |||
}; | |||
|
|||
type StatQueryType = 'country' | 'region' | 'city'; | |||
type GeoMode = 'country' | 'region' | 'city'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the name to avoid confusion between statType
and statQueryType
. Geomode makes a bit more sense and it's the name of the argument of useLocationViewsQuery()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense :)
Preserves the current behavior when not specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes Automattic/jetpack-roadmap#2093.
Proposed Changes
Regions
/Cities
as circle markers, instead of coloring their entire country.Why are these changes being made?
Testing Instructions
/stats/day/jetpack.com?flags=stats/locations
Regions
andCities
tabs close to it.Regions
Cities
Pre-merge Checklist