Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire calypso_signup_actions_submit_step event for Goals step skip button #98067

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

candy02058912
Copy link
Contributor

@candy02058912 candy02058912 commented Jan 8, 2025

Related to #97576
Fixes #97576

Proposed Changes

  • Fire the calypso_signup_actions_submit_step tracks event for the skip button in the Goals step
  • goals property will be empty

image

Why are these changes being made?

  • pfYzsZ-16M-p2#comment-1123

Testing Instructions

  • Go to /setup/onboarding
  • Skip the goals step
  • Check tracks event that calypso_signup_actions_submit_step is being logged with empty goals property
    tracks@2x

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@candy02058912 candy02058912 requested a review from a team January 8, 2025 07:57
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@candy02058912 candy02058912 merged commit b6e45a4 into trunk Jan 8, 2025
15 checks passed
@candy02058912 candy02058912 deleted the update/goals-step-skip-tracks branch January 8, 2025 08:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics for the Goals-first flow
2 participants