Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Picker: Remove Trending for your goals section #98074

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

taipeicoder
Copy link
Contributor

@taipeicoder taipeicoder commented Jan 8, 2025

Related to #97718

Proposed Changes

This PR removes the "Trending for your goals" section since it didn't quite fit with the Design Picker due to it being related to goals instead of category filters.

Screenshot 2025-01-08 at 6 08 49 PM

Why are these changes being made?

#97718 (comment)

Testing Instructions

  • Head to the Design Picker.
  • Smoke-test to ensure it works as intended.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/design-picker-recommended-themes on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 8, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~75 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
link-in-bio-tld-flow        -72 B  (-0.0%)      -32 B  (-0.0%)
update-design-flow          -40 B  (-0.0%)      -21 B  (-0.0%)
themes                      -40 B  (-0.0%)      -21 B  (-0.0%)
signup                      -40 B  (-0.0%)      -21 B  (-0.0%)
marketplace                 -40 B  (-0.0%)      -22 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~20 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks        -40 B  (-0.0%)      -20 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@taipeicoder taipeicoder marked this pull request as ready for review January 8, 2025 13:48
@taipeicoder taipeicoder requested review from arthur791004 and a team January 8, 2025 13:48
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 8, 2025
@taipeicoder taipeicoder self-assigned this Jan 8, 2025
Copy link
Member

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes. LGTM! 🚢

@richtabor
Copy link

I suggest "Best theme matches" rather than "Best matching themes".

It's more natural, conversational, and direct, aligning with user expectations when scanning for relevant options.

@taipeicoder
Copy link
Contributor Author

taipeicoder commented Jan 10, 2025

I suggest "Best theme matches" rather than "Best matching themes".

It's more natural, conversational, and direct, aligning with user expectations when scanning for relevant options.

Sounds good, updated to "Best theme matches" cc: @fditrapani

Screenshot 2025-01-10 at 11 48 44 AM

@taipeicoder taipeicoder merged commit c3996cc into trunk Jan 10, 2025
11 checks passed
@taipeicoder taipeicoder deleted the remove/design-picker-recommended-themes branch January 10, 2025 04:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 10, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17139340

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @taipeicoder for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants