Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent infinite redirect after processing site on onboarding flow #98084

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Jan 8, 2025

Related to #97938

Proposed Changes

  • We're deferring the submit to give React time to update hasActionSuccessfullyRun and avoid infinite redirects.

Why are these changes being made?

  • To prevent infinite loops and console errors

Testing Instructions

  • Open the http://calypso.localhost:3000/setup/onboarding flow
  • Finish the flow and note that after the /setup/site-setup/processing step we don't get the Maximum update depth exceeded error anymore
  • Make sure the redirect works as expected

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/error-while-processing-site on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 8, 2025

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 requested a review from a team January 8, 2025 13:55
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2025
@paulopmt1 paulopmt1 force-pushed the fix/error-while-processing-site branch from 69c05d3 to 9d27a8d Compare January 8, 2025 17:34
Copy link
Contributor

@zaguiini zaguiini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed I'm not getting the error on the console anymore.

@paulopmt1 paulopmt1 merged commit 0a7a9e7 into trunk Jan 8, 2025
11 checks passed
@paulopmt1 paulopmt1 deleted the fix/error-while-processing-site branch January 8, 2025 18:25
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants