Vdimitrakis/2960 evergreen campaign info fixes

[therocket-gr]

Related to

2960-gh-tumblr/a8c-dsp

Proposed Changes

we have some issues in the campaign details page for evergreen campaigns.

1. the duration is not valid (we display 365 days instead of until stopped)

the before version looks like that (we show the start date and then the current day in the run between)

the after version should look like that

2. we have an issue in the outperformed percentages (the calculation was wrong because we check total clicks and total impressions and then we calculate by getting the estimated numbers, but those are on a weekly basis)

example

the new logic will calculate (only for evergreen) the duration past in weeks and then it will divide the clicks and impressions by this number. the result should now be accurate (as we now compare weekly average clicks by the weekly estimated clicks)

3. I noticed that we display orders even when the order is in pending state (so the user has not been charged yet and the order is not completed)

I added a condition to not display those orders

below is a ss with the buggy behaviour

Testing Instructions

some of the changes are hard to test

if you have an active evergreen and an active normal campaign get to the details page for each

1. ensure the info in durations (duration part and run between) are ok
2. ensure the orders are displaying ok
3. ensure the outperformed values (for both campaigns) are somewhat expected

if you don't have active campaigns, you can create 2 (1 evergreen and one normal) and try to play with the variables

for example you can fake the total_clicks (hardcode them) change the campaign status from created (or scheduled to active) and so on to test different scenarios

most importantly do a thorough CR and check out that the logic in calculations seem ok

you re it

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129453

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129453&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129453&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~72 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
promote-post-i2       +128 B  (+0.0%)      +72 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[sbarbosa]

LGTM 👍

[timur987]

Thanks @therocket-gr!

Code LGTM and works as advertised.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug vdimitrakis/2960-evergreen-campaign-info-fixes on your sandbox.