Goals First: Add prop to caypso_signup_start event

[vykes-mac]

Related to #97576

Proposed Changes

• include is_logged_out prop to determine if the flow started from a logged out session

Why are these changes being made?

• To improve data tracking in the flow

Testing Instructions

• Go to /setup/onboarding logged-in and logged-out
• Verify the property is correctly reflecting the logged-out state

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129262

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129262&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129262&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug goals-first/add-prop-to-signup-event on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~39 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
onboarding-flow        +90 B  (+0.4%)      +39 B  (+0.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[skim1220]

Thanks for the quick update, @vykes-mac!

🟢 Signup Start: calypso_signup_start with is_logged_out property

• When initiating the signup flow, calypso_signup_start event fires correctly with is_logged_out: true, as expected 🎉
• We previously added is_goals_first property. Could you provide more context on why is_logged_out property was introduced?

While testing the flow, I found two issues (cc: @autumnfjeld):

🔴 Goals Step: calypso_signup_start event firing multiple times

• Selecting a goal triggers the calypso_signup_start event every time. Here’s a recording.
• calypso_signup_start event should fire only once when a user initiates the signup flow.

🔴 Domain Step: When a user lands on the Domain Step after selecting a goal and a theme,

• calypso_signup_start event fires again. Here’s a recording.
• calypso_signup_actions_submit_step event fires twice when it should fire once. Here’s a recording.
  • The first event is missing intent and goals properties
  • The second event does have intent and goals properties, but does not have is_new_account property.
  • I’m not sure if is_new_account property must be logged here (cc: @MicBosi, @alshakero). It should be logged if it is related to is_new user or is_new_site properties used in other events later in the funnel. It is especially important to ensure is_new_site and is_new_user properties are recorded correctly in calypso_signup_complete event at the later stage.

[vykes-mac]

Thanks for the quick update, @vykes-mac!

🟢 Signup Start: calypso_signup_start with is_logged_out property

• When initiating the signup flow, calypso_signup_start event fires correctly with is_logged_out: true, as expected 🎉
• We previously added is_goals_first property. Could you provide more context on why is_logged_out property was introduced?

While testing the flow, I found two issues (cc: @autumnfjeld):

🔴 Goals Step: calypso_signup_start event firing multiple times

• Selecting a goal triggers the calypso_signup_start event every time. [Here](
  https://github.com/user-attachments/assets/e72f62af-8232-4e9e-b738-2828001d4a56

)’s a recording.

• calypso_signup_start event should fire only once when a user initiates the signup flow.

🔴 Domain Step: When a user lands on the Domain Step after selecting a goal and a theme,

• calypso_signup_start event fires again. [Here](
  https://github.com/user-attachments/assets/fa311b21-c646-43c6-bac5-90564411bcd6

)’s a recording.

• calypso_signup_actions_submit_step event fires twice when it should fire once. [Here](
  https://github.com/user-attachments/assets/fa311b21-c646-43c6-bac5-90564411bcd6

)’s a recording.

• The first event is missing intent and goals properties
• The second event does have intent and goals properties, but does not have is_new_account property.
• I’m not sure if is_new_account property must be logged here (cc: @MicBosi, @alshakero). It should be logged if it is related to is_new user or is_new_site properties used in other events later in the funnel. It is especially important to ensure is_new_site and is_new_user properties are recorded correctly in calypso_signup_complete event at the later stage.

@skim1220 It seems this PR #98083 by @alshakero fixed the duplications issues you mentioned. Once that's merge those issues should be resolved. @alshakero can you confirm here?

[alshakero]

Hi @vykes-mac! Sadly this PR creates two calypso_signup_start events because the extra properties change their value before and after auth when you add is_logged_in. Which makes sense because it will be false before and true after.

[vykes-mac]

Hi @vykes-mac! Sadly this PR creates two calypso_signup_start events because the extra properties change their value before and after auth when you add is_logged_in. Which makes sense because it will be false before and true after.

Was having that issue when selecting goals, should have applied the same
Fix to the is_logged_in so that it does change when the user logs in and
caused the event to fire again

[alshakero]

That should work!