Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up: Remove ai-assembler flow #98200

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Clean-up: Remove ai-assembler flow #98200

merged 2 commits into from
Jan 10, 2025

Conversation

taipeicoder
Copy link
Contributor

@taipeicoder taipeicoder commented Jan 10, 2025

Proposed Changes

This PR remove the ai-assembler flow from the codebase since it's no longer in use.

Why are these changes being made?

p1735002501059149-slack-C06121P56QZ

Testing Instructions

Smoke-test onboarding.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@taipeicoder taipeicoder requested a review from a team as a code owner January 10, 2025 07:39
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@taipeicoder taipeicoder requested a review from a team January 10, 2025 07:40
@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/ai-assembler on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~492 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper              +1187 B  (+0.1%)     +337 B  (+0.1%)
entry-main                 +1097 B  (+0.1%)     +406 B  (+0.1%)
entry-subscriptions         +773 B  (+0.0%)     +251 B  (+0.0%)
entry-login                 +773 B  (+0.0%)     +251 B  (+0.0%)
entry-domains-landing       +773 B  (+0.1%)     +251 B  (+0.1%)
entry-browsehappy           +773 B  (+0.4%)     +251 B  (+0.4%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~5148 bytes removed 📉 [gzipped])

name                                parsed_size             gzip_size
ai-assembler-flow                      -52874 B  (deleted)   -16692 B  (deleted)
plans                                    -226 B    (-0.0%)     -854 B    (-0.2%)
jetpack-connect                          -226 B    (-0.0%)     -854 B    (-0.2%)
jetpack-cloud-pricing                    -226 B    (-0.0%)     -854 B    (-0.4%)
plugin-bundle-flow                       -208 B    (-0.0%)    +1201 B    (+0.7%)
site-purchases                           -199 B    (-0.0%)     -473 B    (-0.1%)
purchases                                -199 B    (-0.0%)     -470 B    (-0.1%)
site-setup-wg                            +196 B    (+0.1%)     +753 B    (+0.7%)
site-setup-flow                          +196 B    (+0.1%)     +753 B    (+0.8%)
readymade-template-flow                  +196 B    (+0.1%)     +703 B    (+1.1%)
gutenberg-editor                         +196 B    (+0.0%)     +763 B    (+0.4%)
hosting                                  +166 B    (+0.0%)    +1169 B    (+0.2%)
domains                                  +166 B    (+0.0%)    +1095 B    (+0.2%)
jetpack-cloud-plugin-management           +92 B    (+0.0%)     +689 B    (+0.1%)
plugins                                   +62 B    (+0.0%)     +679 B    (+0.1%)
onboarding-flow                           +54 B    (+0.2%)      +15 B    (+0.2%)
link-in-bio-tld-flow                      -36 B    (-0.0%)      +36 B    (+0.0%)
site-overview                             -30 B    (-0.0%)      -14 B    (-0.0%)
site-blocks                               -30 B    (-0.0%)      -11 B    (-0.0%)
settings                                  -30 B    (-0.0%)     +109 B    (+0.0%)
security                                  -30 B    (-0.0%)      -11 B    (-0.0%)
privacy                                   -30 B    (-0.0%)      -11 B    (-0.0%)
notification-settings                     -30 B    (-0.0%)      -11 B    (-0.0%)
me                                        -30 B    (-0.0%)      -11 B    (-0.0%)
jetpack-cloud-settings                    -30 B    (-0.0%)      -59 B    (-0.0%)
jetpack-cloud-features-comparison         -30 B    (-0.0%)      +12 B    (+0.0%)
jetpack-app                               -30 B    (-0.0%)      -10 B    (-0.0%)
home                                      -30 B    (-0.0%)      -27 B    (-0.0%)
help                                      -30 B    (-0.0%)      -11 B    (-0.0%)
email                                     -30 B    (-0.0%)     -180 B    (-0.1%)
developer                                 -30 B    (-0.0%)      -11 B    (-0.0%)
account-close                             -30 B    (-0.0%)      -11 B    (-0.0%)
account                                   -30 B    (-0.0%)      -11 B    (-0.0%)
signup                                    -29 B    (-0.0%)      +40 B    (+0.1%)
start-writing-flow                        +27 B    (+0.1%)      +19 B    (+0.2%)
reblogging-flow                           +27 B    (+0.3%)      +18 B    (+0.9%)
pages                                     +27 B    (+0.0%)     +223 B    (+0.1%)
newsletter-flow                           +27 B    (+0.1%)      +18 B    (+0.2%)
new-hosted-site-flow-user-included        +27 B    (+0.0%)      +21 B    (+0.0%)
new-hosted-site-flow                      +27 B    (+0.0%)      +18 B    (+0.0%)
import-hosted-site-flow                   -27 B    (-0.0%)      -16 B    (-0.0%)
devdocs                                   +27 B    (+0.0%)      +27 B    (+0.0%)
design-first-flow                         +27 B    (+0.1%)      +17 B    (+0.2%)
copy-site-flow                            -27 B    (-0.0%)      -17 B    (-0.0%)
connect-domain                            +27 B    (+0.0%)      +28 B    (+0.1%)
assembler-first-flow                      +27 B    (+0.0%)      +58 B    (+0.1%)
site-settings                             -17 B    (-0.0%)      +80 B    (+0.0%)
hosting-features                          +13 B    (+0.0%)     +146 B    (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~171 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-purchase-modal-wrapper                                                       -30 B  (-0.0%)       -9 B  (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -30 B  (-0.0%)       -9 B  (-0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice                        -30 B  (-0.1%)      -14 B  (-0.2%)
async-load-calypso-layout-masterbar-checkout                                            -30 B  (-0.0%)      -18 B  (-0.1%)
async-load-calypso-blocks-editor-checkout-modal                                         -30 B  (-0.0%)     +237 B  (+0.1%)
async-load-design                                                                       +13 B  (+0.0%)      -16 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@taipeicoder taipeicoder merged commit ed3de06 into trunk Jan 10, 2025
11 checks passed
@taipeicoder taipeicoder deleted the remove/ai-assembler branch January 10, 2025 08:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants