Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deisgn picker: Include partial category matches in best matching results #98205

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

madhusudhand
Copy link
Member

Fixes https://github.com/Automattic/dotcom-forge/issues/10222

Proposed Changes

  • Includes partial category matches in best matching results (with at least 2 categories are matched)
  • Sorts the best matching results by number of category matches (4, 3, 2 etc..)
  • Limits the results to a maximum of 6

Testing Instructions

  • Visit design picker at: /setup/site-setup/designSetup?siteSlug=:slug&siteId=:id&categories=blog%2Cnewsletter
  • Try filtering results with multiple categories
  • Partial category matching results must be shown (compare with production version)
  • Results with highest matching categories must appear first.
  • At most 6 results should be shown.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@madhusudhand madhusudhand requested a review from a team January 10, 2025 09:26
@madhusudhand madhusudhand self-assigned this Jan 10, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 10, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants