Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging sites: Update error notice message when Studio import is in progress #98216

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Jan 10, 2025

Resolves https://github.com/Automattic/dotcom-forge/issues/10008.

Proposed Changes

  • update error notice message when Studio import is in progress

Markup on 2025-01-10 at 14:40:12

Note

I originally aimed to adjust the error logic on a deeper level (as can be seen in #98156), but then decided to adjust the error message only.

The changes proposed in this PR are much simpler and solve the issue without touching the error logic.

Why are these changes being made?

Testing Instructions

  1. Create an Atomic site and ensure it also has a staging site attached (http://calypso.localhost:3000/staging-site/{site-slug}).
  2. Open the Studio app and connect the Atomic site to one of your local sites.
  3. Initiate the Push operation to your staging site and wait until the Applying changes... status message displays above the progress bar.
  4. Head over to the http://calypso.localhost:3000/staging-site/{site-slug} settings page and try to initiate the sync from production to the staging site.
  5. The process should fail with the new error message - as can be seen in the screenshot above.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ivan-ottinger ivan-ottinger self-assigned this Jan 10, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~46 bytes added 📈 [gzipped])

name          parsed_size           gzip_size
staging-site       +128 B  (+0.0%)      +46 B  (+0.0%)
site-tools         +128 B  (+0.0%)      +46 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/staging-sync-error-message-on-studio-push-in-progress on your sandbox.

@ivan-ottinger ivan-ottinger force-pushed the update/staging-sync-error-message-on-studio-push-in-progress branch from 2512104 to 6165cb3 Compare January 10, 2025 13:43
@ivan-ottinger ivan-ottinger requested a review from a team January 10, 2025 14:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants