Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: ignore ref changes when customizing calypso_signup_start #98235

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Jan 10, 2025

Testing Instructions

  1. Go to 22138-explat-experiment
  2. Save the treatment bookmarklet.
  3. While incognito, go to Calypso My Home / (don't go to the flow URL, the experiment assignment will be cached).
  4. Open DevTools > Network and filter by calypso_signup_start.
  5. Click the bookmarklet.
  6. Visit /setup/onboarding?ref=lohp.
  7. You should see a single instance of calypso_signup_start.
  8. Go on to sign up.
  9. After auth, you shouldn't seemore instances of calypso_signup_start.

@alshakero alshakero requested a review from a team as a code owner January 10, 2025 22:14
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@alshakero alshakero added the Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. label Jan 10, 2025
@alshakero alshakero changed the title Stepper: ignore ref changes when customize calypso_signup_start Stepper: ignore ref changes when customizing calypso_signup_start Jan 10, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug tracks/ignore-ref-changes on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~0 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +39 B  (+0.0%)       +0 B

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@vykes-mac vykes-mac merged commit b21d41c into trunk Jan 10, 2025
11 checks passed
@vykes-mac vykes-mac deleted the tracks/ignore-ref-changes branch January 10, 2025 22:47
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@escapemanuele escapemanuele requested a review from a team January 13, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants