HC: play notification sound on message received

[heavyweight]

Related to #
#97702

Proposed Changes

• Play notification sound on message received

Why are these changes being made?

• With soundNotificationEnabled setting on, notification sounds were not playing
• This PR adds:
  • Setting for notification sounds
  • Updates the conversation ellipsis menu to enable toggling of this setting
  • Wires this setting and plays notification sound programatically on message received

Testing Instructions

• Use PR link or build the PR
• Open a zd conversation
• Send messages from zd to a chat with your testing user
• Notification sound should be played
• Open the ellipsis menu and turn off the sounds
• Send messages from zd again
• Notification sound should not be played this time on message received

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131037

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131037&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131037&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• help-center
• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/hc-notification-sound on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~80 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +338 B  (+0.0%)      +80 B  (+0.0%)
entry-main          +338 B  (+0.0%)      +76 B  (+0.0%)
entry-login         +338 B  (+0.0%)      +76 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Async-loaded Components (~1069 bytes added 📈 [gzipped])

name                                            parsed_size           gzip_size
async-load-automattic-help-center-stepper           +4437 B  (+0.5%)    +1114 B  (+0.4%)
async-load-automattic-help-center                   +3706 B  (+0.6%)     +955 B  (+0.5%)
async-load-design-wordpress-components-gallery        +13 B  (+0.0%)      +23 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[escapemanuele]

What do you think of this @fditrapani ?

[escapemanuele]

Sounds good!

[fditrapani]

While I wait for Calypso live to build. Here are some quick points of feedback based on the video you shared in Slack. Can we replace the icon with the Comment Icon in the WordPress icon library:

The rollover over the entire toggle doesn't look right or align how our toggles work anywhere else. Can we remove it?

[fditrapani]

Nailed it! Thanks for the extra attention to detail. This works great now.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17208889

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @heavyweight, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Notification sound

Thank you in advance!

[a8ci18n]

Translation for this Pull Request has now been finished.