Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Add On: Allow higher term cart item to be added via query param #98899

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

ddc22
Copy link
Contributor

@ddc22 ddc22 commented Jan 24, 2025

Proposed Changes

  • Allow addition of storage of higher tiers via query param from landing pages

Why are these changes being made?

  • Allow landing pages to directly add storage addons to the cart

Testing Instructions

  • Go to /start/business/?ref=pricing-lp&storage=400gb-storage-add-on
  • Select domain
  • Make sure the 400gb add on is added to the card
  • Also should work with any of these variations
    • 400gb-storage-add-on
    • 350gb-storage-add-on
    • 300gb-storage-add-on
    • 250gb-storage-add-on
    • 200gb-storage-add-on
    • 150gb-storage-add-on
    • 100gb-storage-add-on
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 24, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~8720 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
signup                       +6263 B  (+2.1%)    +2102 B  (+3.2%)
stats                         +288 B  (+0.0%)      +79 B  (+0.0%)
site-overview                 +288 B  (+0.0%)      +42 B  (+0.0%)
plugins                       +288 B  (+0.0%)     +235 B  (+0.0%)
theme                         +275 B  (+0.0%)      +71 B  (+0.0%)
site-purchases                +275 B  (+0.0%)      +67 B  (+0.0%)
purchases                     +275 B  (+0.0%)      +67 B  (+0.0%)
posts-custom                  +275 B  (+0.0%)      +47 B  (+0.0%)
posts                         +275 B  (+0.0%)      +47 B  (+0.0%)
plans                         +275 B  (+0.0%)      +44 B  (+0.0%)
migrate                       +275 B  (+0.1%)      +46 B  (+0.0%)
jetpack-app                   +275 B  (+0.1%)     +240 B  (+0.2%)
import-hosted-site-flow       +275 B  (+0.0%)     +184 B  (+0.0%)
hosting                       +275 B  (+0.0%)      +67 B  (+0.0%)
domains                       +275 B  (+0.0%)      +67 B  (+0.0%)
checkout                      +275 B  (+0.0%)      +58 B  (+0.0%)
add-ons                       +275 B  (+0.1%)      +55 B  (+0.1%)
update-design-flow            +231 B  (+0.0%)     +291 B  (+0.1%)
link-in-bio-tld-flow          +231 B  (+0.0%)     +291 B  (+0.0%)
tailored-ecommerce-flow        +27 B  (+0.4%)      +17 B  (+0.8%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1764 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected      -6032 B  (-1.3%)    -1811 B  (-1.2%)
async-load-signup-steps-plans                        -6032 B  (-1.3%)    -1811 B  (-1.2%)
async-load-design-blocks                              +275 B  (+0.0%)      +47 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Jan 24, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/storage-add-on-definition on your sandbox.

@ddc22 ddc22 self-assigned this Jan 24, 2025
@ddc22 ddc22 requested review from aneeshd16 and a team January 24, 2025 17:11
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2025
@ddc22 ddc22 marked this pull request as ready for review January 24, 2025 17:11
@ddc22 ddc22 requested a review from aneeshd16 January 27, 2025 18:07
Copy link
Contributor

@aneeshd16 aneeshd16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great after the change! Can you please add the Tracks event?

@ddc22
Copy link
Contributor Author

ddc22 commented Jan 29, 2025

@aneeshd16 sorry somehow the change slipped through the cracks.

@ddc22 ddc22 requested a review from aneeshd16 January 29, 2025 17:21
Copy link
Contributor

@aneeshd16 aneeshd16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think you would need to rebase before merging this as the E2E tests are failing.

@ddc22 ddc22 force-pushed the add/storage-add-on-definition branch from ea9ff5e to c85e182 Compare January 31, 2025 15:16
@ddc22 ddc22 merged commit f82b613 into trunk Jan 31, 2025
10 of 13 checks passed
@ddc22 ddc22 deleted the add/storage-add-on-definition branch January 31, 2025 15:26
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants