Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Migrate Serial Comm Node to AMP_ASSv2 #7

Open
1 of 3 tasks
zghera opened this issue Feb 10, 2022 · 1 comment
Open
1 of 3 tasks

Migrate Serial Comm Node to AMP_ASSv2 #7

zghera opened this issue Feb 10, 2022 · 1 comment
Assignees
Labels
serial Related to the serial communication package of the ASS.

Comments

@zghera
Copy link
Member

zghera commented Feb 10, 2022

Description

We need to move the current state of the serial communication node from AMP_ASSv1 to AMP_ASSv2.

Ideally with PRs we shoot for a single, small, tested addition to make everyone's (code reviewers, anyone who wants to go through the commit history, etc.) lives easier. However, the evolution of the serial comm code has been an... adventure. Given the circumstances, this issue (and the associated PR) involves moving over all of the critical code from the ti_comm folder (in ~/src) based on the state of the ti_comm_dev branch now (i.e. as of this commit).

These components include:

  • The ROS package and necessary source files (e.g. CMakeLists.txt, amp_serial_jetson.cpp, etc.)
  • The current libserialport folder as a git submodule.
  • The build script.

Another note: now that we have the chance to "start anew," we should make some efforts to rename things appropriately. Including but not limited to:

  • ti_comm(_node) -> serial_comm(_node).
  • amp_serial_jetson.cpp -> serial_comm.cpp (or something similar and consistent with the package name).

No other code related to new projects should be moved over (i.e. the ones in #8 and #9).

Sub-tasks

  • Create new serial_comm repo.
  • Rename and clean up codebase to minimize repetition and unnecessary descriptors.
  • Include the submodule to this code base

Resources

  • ...
@zghera zghera added ASS enhancement New feature or request serial Related to the serial communication package of the ASS. labels Feb 10, 2022
@zghera zghera added draft This needs to be fleshed out with more detail. and removed ASS enhancement New feature or request labels Feb 15, 2022
@alanssitis
Copy link
Contributor

Talked with @aaaakshat and @FraserD404 on how to approach this. Might be best to have the serial node be in its own repository and have it be imported as a submodule.

This option will allow serial to have multiple working branches without affecting this repo and give us better control on the version of serial comm used.

@alanssitis alanssitis removed the draft This needs to be fleshed out with more detail. label Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
serial Related to the serial communication package of the ASS.
Projects
None yet
Development

No branches or pull requests

4 participants