-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created drop down menu for responsive devices and hide that menu in l… #186
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
@Avdhesh-Varshney please check this and merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruv8433 loading is done many times, loader is called again and again. Try to resolve it.
Also I think, it's not looks attractive with the theme of the website.
ok i will do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruv8433 LGTM. But color of All
is not the dark blue so change it.
Why have you update single quotes into double quotes? and tab size from 4 to 2?
This makes pr review difficult, so always push your updated code only not change the style or formatting. OK.
And join discord, it will easy to mentained the pr clear.
@dhruv8433 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now you can check now filter is workin properly |
Hey @Avdhesh-Varshney ,review it and merged it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruv8433 it's still not looks good and re-create the pr again by updating your forked repository.
@Avdhesh-Varshney
…arge screens
Pull Request for WebMasterLog 💡
Issue Title:
Enhancement 🧑💻: We can provide drop down list instead of static opetaions in single line #183
Closes: #183
Describe the add-ons or changes you've made 📃
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
Checklist: ☑️
Screenshots 📷
in large pc screen
in responsive devices
Note to reviewers 📄