Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop down #204

Merged
merged 7 commits into from
Jun 2, 2024
Merged

Drop down #204

merged 7 commits into from
Jun 2, 2024

Conversation

dhruv8433
Copy link
Contributor

@dhruv8433 dhruv8433 commented May 29, 2024

Pull Request for WebMasterLog πŸ’‘

Enhancement πŸ§‘β€πŸ’»: We can provide drop down list instead of static opetaions in single line #183

Issue Title: Enhancement πŸ§‘β€πŸ’»: We can provide drop down list instead of static opetaions in single line

Closes: #183

Describe the add-ons or changes you've made πŸ“ƒ

Give a clear description of what have you added or modifications made

  • created drop down for responsive devices
  • update color of drop down as per theme

Type of change β˜‘οΈ

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? βš™οΈ

  • check output in responsive devices

Checklist: β˜‘οΈ

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots πŸ“·

Note to reviewers πŸ“„

for all option selected we got
image

for easy option
image

for medium
image

and for hard option
image

Copy link

vercel bot commented May 29, 2024

@dhruv8433 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@dhruv8433
Copy link
Contributor Author

please inform me if you need any kind of improvement

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-master-log βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 31, 2024 9:55am

@dhruv8433
Copy link
Contributor Author

@Avdhesh-Varshney

Please check it and merge it

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruv8433 I think you have still raised the same changes in the pr.
Not Approved. I will not tell you again and again, either change the code as mentioned in earliest prs or communicate to other contributors as well on discord server.

@dhruv8433
Copy link
Contributor Author

@Avdhesh-Varshney

i pulled newly added code and change style of drop down
set dropdown theme as option theme
you can check that

image

image

image

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented May 31, 2024

hope you like it
please check that and merge that

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruv8433 PR Approved πŸŽ‰

@Avdhesh-Varshney Avdhesh-Varshney merged commit edd0e85 into Avdhesh-Varshney:main Jun 2, 2024
4 checks passed
@Avdhesh-Varshney
Copy link
Owner

@dhruv8433 Carefully linked your pr.

@dhruv8433
Copy link
Contributor Author

Thank You : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement πŸ§‘β€πŸ’»: We can provide drop down list instead of static opetaions in single line
2 participants