Virtual piano #289
Closed
Virtual piano #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
Avdhesh-Varshney
requested changes
Jun 11, 2024
There was a problem hiding this comment.
@VaishnaviMankala19 LGTM. But change the directory named to Virtual-Piano
|
Can i get level2 for this @Avdhesh-Varshney |
Avdhesh-Varshney
requested changes
Jun 12, 2024
There was a problem hiding this comment.
@VaishnaviMankala19 change Virtual-piano folder name to Virtual-Piano and resolve the merge conflicts.
changing directory name
changed readme name
file name
|
@Avdhesh-Varshney please review my pr |
|
@VaishnaviMankala19 again raise your pr with proper guidelines. It can't be approved as there are 34 commits for a single project addition. |
Avdhesh-Varshney
added
bug 🐛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #271
Describe the add-ons or changes you've made 📃
I have added Virtual-Piano in Vanilla.js>basic , updated readme and database
How Has This Been Tested? ⚙️
Screenshots 📷
Type of change ☑️
What sort of change have you made:
Checklist: ☑️
Note to reviewers 📄