Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Anagram Checker: #358 #371

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Conversation

Anshika14528
Copy link
Contributor

Closes: #358

  • Title : Anagram Checker
  • Name: : Anshika
  • Idenitfy yourself: : GSSOC

Describe the add-ons or changes you've made 📃

Added Anagram Checker which tells us if two strings are anagram or not.

How Has This Been Tested? ⚙️

I have testes it on my own.

Screenshots 📷

Screenshot 2024-06-21 at 8 20 16 PM screenshotss

Type of change ☑️

  • New feature (non-breaking change which adds functionality)

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 3:33pm

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Anshika14528
Copy link
Contributor Author

@Avdhesh-Varshney sir, please review it

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anshika14528 keep it inside Basic folder go according to label mentioned on issues and enlist your project in the readme file of Vanilla-JS

Vanilla-JS-Projects/Intermediate/Anagram-Checker/README.md Outdated Show resolved Hide resolved
@Anshika14528
Copy link
Contributor Author

@Avdhesh-Varshney sir, i have made the required changes please review it now

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anshika14528 PR Approved 🎉

@Avdhesh-Varshney Avdhesh-Varshney merged commit 58e72ea into Avdhesh-Varshney:main Jun 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Anagram Checker:
2 participants