Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 404 page #422

Closed
wants to merge 4 commits into from
Closed

added 404 page #422

wants to merge 4 commits into from

Conversation

Jagpreet153
Copy link

@Jagpreet153 Jagpreet153 commented Jun 28, 2024

Closes: #402

  • 404 Error Page :
  • Name: : Jagpreet Singh Khurana
  • Idenitfy yourself: : GSSOC'24

Describe the add-ons or changes you've made 📃

Added a home button and animation of 404 page using lottie animation

How Has This Been Tested? ⚙️

I have checked the changes locally on my environment

Screenshots 📷

Screenshot 2024-06-28 143651

Type of change ☑️

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Kindly review this PR

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 6:33am

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jagpreet153 working is good. But page is not looks nice.

@Jagpreet153
Copy link
Author

Ok @Avdhesh-Varshney . I will add another animation

@Jagpreet153
Copy link
Author

@Avdhesh-Varshney Is it looking ok

Screenshot 2024-06-30 113922

@Avdhesh-Varshney
Copy link
Owner

@Jagpreet153 you can review your deployed pr link. It's similar to the last view.

@Jagpreet153
Copy link
Author

@Avdhesh-Varshney I have changed the animation to this... Kindly have a review.

@Avdhesh-Varshney Is it looking ok

Screenshot 2024-06-30 113922

I have changed the animation to this . Kindly have a review .

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jagpreet153 looks good. But i've rebase the code of website yesterday. So, there're a lots of conflicts. You have to raise your pr again and not commit in main branch.

Also, use only boostrap css only. I've removed css files of all components which are un-necessary.

@Avdhesh-Varshney Avdhesh-Varshney added the wontfix ❌ This will not be worked on label Jul 3, 2024
@Jagpreet153
Copy link
Author

Ok @Avdhesh-Varshney I would be raising PR agian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Status: Requested Changes wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: 404 Error page
2 participants