Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project : GasGuys HomePage Clone added #468

Closed
wants to merge 2 commits into from

Conversation

GAVINESHWAR
Copy link
Contributor

Closes:
issue : #463

  • Title : GasGuys Home Page Clone
  • Name: : G Avineshwar
  • Idenitfy yourself: : GSSOC

Describe the add-ons or changes you've made 📃

It is an home page developed using HTML, CSS and JavaScript with fully responsive website.

How Has This Been Tested? ⚙️

Screenshots 📷

Screenshot 2024-07-04 193747

Screenshot 2024-07-04 193818

Screenshot 2024-07-04 193828

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

@Avdhesh-Varshney , I PR the issue check my changes and merge the changes to make contribution to the project.

Thank you

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 1:30pm

Copy link

github-actions bot commented Jul 5, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GAVINESHWAR as use of js, keep it inside the vanilla js directory

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't distort the alignment and resolve the merge conflicts

@GAVINESHWAR
Copy link
Contributor Author

@GAVINESHWAR as use of js, keep it inside the vanilla js directory

@Avdhesh-Varshney Could specify basic,intermediate and advanced folder as well .

@Avdhesh-Varshney
Copy link
Owner

@GAVINESHWAR as use of js, keep it inside the vanilla js directory

@Avdhesh-Varshney Could specify basic,intermediate and advanced folder as well .

based on the attached labels level2 -> Intermediate ok

@GAVINESHWAR GAVINESHWAR mentioned this pull request Jul 6, 2024
9 tasks
@GAVINESHWAR
Copy link
Contributor Author

@Avdhesh-Varshney , I closed this issue due to conflicts and opened new PR please go through it.

Thank you

@GAVINESHWAR GAVINESHWAR closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Status: Requested Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants