Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Electronic drum kit Project #915

Merged

Conversation

JomanaMahmoud
Copy link
Contributor

Closes: #92

  • Title: Electronic Drum Kit
  • Name: Jomana Tantawy
  • Idenitfy yourself: Contributor in GSSOC-EXT and Hacktoberfest

Describe the add-ons or changes you've made 📃

In this update, I added a new Electric Drum Kit feature to the project under the vanilla-js folder. This project allows users to create drum beats by clicking on buttons or pressing corresponding keys on the keyboard, which trigger sounds for different drum components. Additionally, I've ensured that the interactive drum keys display a hover effect when pressed. This fun and dynamic project adds an exciting element to the website, allowing for both mouse and keyboard interaction. The implementation enhances user experience and brings more interactive functionality to the project.

Screenshots 📷

screenshot

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Copy link

vercel bot commented Oct 15, 2024

@JomanaMahmoud is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Avdhesh-Varshney Avdhesh-Varshney merged commit 6d8db11 into Avdhesh-Varshney:main Oct 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electronic Drum Kit using Vanilla JS
2 participants