Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ProgressBar | Issue #879 #943

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

Shariq2003
Copy link
Contributor

Closes: #879

  • Title: Added ProgressBar
  • Name: Shariq
  • Idenitfy yourself:
    GSSOC Ext

Describe the add-ons or changes you've made 📃

I have added a progress bar.

bandicam.2024-10-18.02-26-57-015.mp4

Screenshots 📷

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Copy link

vercel bot commented Oct 17, 2024

@Shariq2003 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 6:00am

@Shariq2003
Copy link
Contributor Author

@Avdhesh-Varshney sir, please review and merge this

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work. Make the same color of progressbar as of scrollbar

webmasterlog/src/app/globals.css Show resolved Hide resolved
@Shariq2003
Copy link
Contributor Author

@Avdhesh-Varshney sir, please review and merge

@Shariq2003
Copy link
Contributor Author

Nice Work. Make the same color of progressbar as of scrollbar

Yes, its same

@Avdhesh-Varshney Avdhesh-Varshney merged commit 625b7c2 into Avdhesh-Varshney:main Oct 20, 2024
4 checks passed
@NEGRAH-S
Copy link

@MastanSayyad , only one file changed and readymade component added Level 1 should be assigned

@Shariq2003
Copy link
Contributor Author

Shariq2003 commented Oct 25, 2024

@MastanSayyad , only one file changed and readymade component added Level 1 should be assigned

@NEGRAH-S Sir, in Webdev everything is already implemented somewhere, but that doesn't mean it is like a cherry on the cake for me. I am also not a highly skilled developer, just participated in GSSOC Ext to improve.
Addition of a feature should be counted as level 2

@NEGRAH-S Sir please review .

Copy link
Contributor

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Addition of Progress Bar for Scrolling Just Like in GSSOC Website
4 participants