Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #955 #972

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fixed issue #955 #972

merged 1 commit into from
Oct 21, 2024

Conversation

LNischala
Copy link
Contributor

Closes: issue #955

-Title: Add icons for email and password and also the onclick functionality for password icon in LoginSignUpForm (Front-end project)
-Name: Nischala Lakkaraju
-Idenitfy yourself: GSSoc Extd 2024 contributer
-Describe the add-ons or changes you've made 📃
I have added the required icons beside the input fields and implemented the functionality of the password toggle icon. The locked icon ensures the password is secured and the unlock icon shows the entered password.
Additionally, I also changed the color of 'Login' and 'Sign up' for better visibility. If this additional change isn't needed, let me know to undo it.
BEFORE->
weblogin1

AFTER->

Screenshots 📷

webloginup
webloginyp1
websignupup

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never commit directly in main branch.
This time, I've approved it.

@Avdhesh-Varshney Avdhesh-Varshney merged commit 9a80e76 into Avdhesh-Varshney:main Oct 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants