-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shadow, proper padding along with highlight #43
base: master
Are you sure you want to change the base?
Conversation
This reverts commit d747ebd.
@ritikasource Provide a demo link for the changes you made. |
The demo link for the implementation: https://codepen.io/ritika-source/pen/vYOzyqd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritikasource it looks good butit will be great if you can add some colored border to the fields too.
@yellowwoods12 okay would add that too! |
Is this fine: https://codepen.io/ritika-source/pen/vYOzyqd @yellowwoods12? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritikasource The colors could have been better but I think we can merge it for now. @plxity Can you have a look and merge it.
@ritikasource Branch has conflicts, you should resolve it first, and please raise a PR for the development branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritikasource I guess there is no need to commit the package-lock.json file here.
Added shadow and padding along with highlighting effects in the input fields however I am facing an issue in including the font-awesome check icon in the Pincode input field.