Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shadow, proper padding along with highlight #43

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ritikasource
Copy link

@ritikasource ritikasource commented Mar 20, 2020

Added shadow and padding along with highlighting effects in the input fields however I am facing an issue in including the font-awesome check icon in the Pincode input field.

@plxity
Copy link
Collaborator

plxity commented Mar 21, 2020

@ritikasource Provide a demo link for the changes you made.

@ritikasource
Copy link
Author

The demo link for the implementation: https://codepen.io/ritika-source/pen/vYOzyqd

Copy link
Collaborator

@yellowwoods12 yellowwoods12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritikasource it looks good butit will be great if you can add some colored border to the fields too.

@ritikasource
Copy link
Author

@yellowwoods12 okay would add that too!

@ritikasource
Copy link
Author

Copy link
Collaborator

@yellowwoods12 yellowwoods12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritikasource The colors could have been better but I think we can merge it for now. @plxity Can you have a look and merge it.

@plxity
Copy link
Collaborator

plxity commented May 30, 2020

@ritikasource Branch has conflicts, you should resolve it first, and please raise a PR for the development branch.

Copy link
Member

@arpit9667 arpit9667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritikasource I guess there is no need to commit the package-lock.json file here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants