Fix required fields check on csv upload #618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent self user delete
update CI and readme
add checkout
set fetch-depth
update links, allow working without tags
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…4.0.8 Bump micromatch from 4.0.5 to 4.0.8
Fix user's Edit action defualt Tab not being shown
This PR is almost copy of Awesome-Technologies/synapse-admin#601 PR, authored by @dklimpel
This is almost copy of Awesome-Technologies/synapse-admin#573 PR, authored by @huw1990
For example, erased users don't have display name, so header was `User "null"`. With this change, if there is no display name, the MXID will be show, e.g. `User "@user:example.com"`
Fix user's display name in header on user's page
This is almost a copy of Awesome-Technologies/synapse-admin#574 (comment) suggestion, authored by @ll-SKY-ll
… as it causes issues with CDN deploy - workflow should be adjusted first This reverts commit 317df5a.
* Fix redirect URL after user creation * increment version; update readme
* Display actual synapse errors * Show actual errors from dataProvider requests * update README
* Fix base_url being undefined on unsuccessful login * update readme
This commit fixes the Awesome-Technologies/synapse-admin#507 issue. While it's a mere workaround, it may help until the Awesome-Technologies/synapse-admin#507 (comment) is implemented
…ate (#19) Federation page improvements This is almost a copy of Awesome-Technologies/synapse-admin#583 PR, authored by @rkfg
Add UI option to block deleted rooms from being rejoined This is almost a copy of Awesome-Technologies/synapse-admin#166 PR, authored by @jkanefendt
|
sorry, wrong base branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is originally mentioned in the #552, but the actual reason is a bit different.
Attached file "example-bad.csv" contains a supposedly good file for import that fails either with "required field
displaynameis missing" or with "required fieldidis missing"Attached file "example-good.csv"
contains an unexpectedly good file for import that passes the required fields check (note that in this file
idis renamed asi_danddisplaynameis renamed asdisplay_name).Nevertheless, even after that synapse-admin does not see IDs
example-bad.csv
example-good.csv